Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for UpdateDatabase in Cloud Spanner #2265

Merged
merged 12 commits into from May 15, 2023
Merged

feat: add support for UpdateDatabase in Cloud Spanner #2265

merged 12 commits into from May 15, 2023

Conversation

aayushimalik
Copy link
Contributor

No description provided.

@aayushimalik aayushimalik requested a review from a team as a code owner February 6, 2023 13:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 6, 2023
@aayushimalik aayushimalik marked this pull request as draft February 6, 2023 13:41
rajatbhatta
rajatbhatta reviewed Feb 7, 2023
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Outdated Show resolved Hide resolved
@rajatbhatta
Copy link
Contributor

@aayushimalik: Can you please add unit tests for the handwritten changes as well (in addition to the integration test you've added)?

@rajatbhatta
Copy link
Contributor

Please create a separate PR for samples and sample tests for Drop Database Protection.

@aayushimalik
feature: Cloud Spanner Drop Database Protection
c225c2c
@aayushimalik
Merge remote-tracking branch 'origin/spanner-update-database' into sp…
1b9b5d7 
…anner-update-database

# Conflicts:
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClientImpl.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseAdminClientImplTest.java
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 13, 2023
@aayushimalik aayushimalik marked this pull request as ready for review April 4, 2023 03:29
@rajatbhatta rajatbhatta changed the title feature: Cloud Spanner Drop Database Protection feat: Cloud Spanner Drop Database Protection Apr 4, 2023
@rajatbhatta rajatbhatta changed the title feat: Cloud Spanner Drop Database Protection feat: add support for UpdateDatabase in Cloud Spanner Apr 4, 2023
rajatbhatta
rajatbhatta reviewed Apr 4, 2023
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseAdminTest.java Outdated Show resolved Hide resolved
rajatbhatta
rajatbhatta approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushimalik: Thank you for your patience with me on this PR. LGTM.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 15, 2023 10:58
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 15, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@rajatbhatta rajatbhatta merged commit 2ea06e7 into googleapis:main May 15, 2023
21 of 23 checks passed
@release-please release-please bot mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aayushimalik @rajatbhatta @yoshi-kokoro