Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use streaming read/query settings for stream retry #2579

Merged
merged 3 commits into from Aug 17, 2023

Conversation

olavloite
Copy link
Collaborator

Use the streaming read/query settings from the SpannerStubSettings to determine when and how to retry a failure halfway a streaming call.

Use the streaming read/query settings from the SpannerStubSettings to
determine when and how to retry a failure halfway a streaming call.
@olavloite olavloite requested review from a team as code owners August 10, 2023 18:59
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 10, 2023
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@olavloite olavloite merged commit f78b838 into main Aug 17, 2023
23 of 24 checks passed
@olavloite olavloite deleted the apply-streaming-retry-settings branch August 17, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants