Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getColumnCount would fail for empty partititioned result sets #2588

Merged
merged 1 commit into from Aug 14, 2023

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Aug 14, 2023

Calling getColumnCount() would fail for empty ResultSets that were returned for partitioned queries. The reason for this was that the number of columns would be calculated based on the last seen row. This would not work for ResultSets without any rows at all.

Calling getColumnCount() would fail for ResultSets that were returned for partitioned
queries. The reason for this was that the number of columns would be calculated based
on the last seen row. This would not work for ResultSets without any rows at all.
@olavloite olavloite requested a review from a team as a code owner August 14, 2023 10:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 14, 2023
@olavloite olavloite merged commit 9a2f3fc into main Aug 14, 2023
23 of 24 checks passed
@olavloite olavloite deleted the metadata-for-empty-result-sets branch August 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants