Skip to content

Commit 8a7755c

Browse files
gcf-owl-bot[bot]BenWhitehead
andauthoredMay 19, 2022
feat: change GCS gRPC API to get user billing project from gRPC metadata instead of CommonRequestParams, and remove latter (#1396)
* feat: Change GCS gRPC API to get user billing project from gRPC metadata instead of CommonRequestParams, and remove latter PiperOrigin-RevId: 449498085 Source-Link: googleapis/googleapis@d4444af Source-Link: https://github.com/googleapis/googleapis-gen/commit/e13d4f4fb4110f78ee86019a3d5408fe573eb289 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTEzZDRmNGZiNDExMGY3OGVlODYwMTlhM2Q1NDA4ZmU1NzNlYjI4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update clirr rules to allow removal of google/storage/v2/CommonRequestParams message Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
1 parent 8834423 commit 8a7755c

File tree

57 files changed

+636
-8180
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+636
-8180
lines changed
 

‎gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageClient.java

+4-45
Large diffs are not rendered by default.

‎gapic-google-cloud-storage-v2/src/test/java/com/google/storage/v2/StorageClientTest.java

-13
Original file line numberDiff line numberDiff line change
@@ -1349,7 +1349,6 @@ public void composeObjectTest() throws Exception {
13491349
CryptoKeyName.of("[PROJECT]", "[LOCATION]", "[KEY_RING]", "[CRYPTO_KEY]")
13501350
.toString())
13511351
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1352-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
13531352
.build();
13541353

13551354
Object actualResponse = client.composeObject(request);
@@ -1369,7 +1368,6 @@ public void composeObjectTest() throws Exception {
13691368
Assert.assertEquals(request.getKmsKey(), actualRequest.getKmsKey());
13701369
Assert.assertEquals(
13711370
request.getCommonObjectRequestParams(), actualRequest.getCommonObjectRequestParams());
1372-
Assert.assertEquals(request.getCommonRequestParams(), actualRequest.getCommonRequestParams());
13731371
Assert.assertTrue(
13741372
channelProvider.isHeaderSent(
13751373
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
@@ -1393,7 +1391,6 @@ public void composeObjectExceptionTest() throws Exception {
13931391
CryptoKeyName.of("[PROJECT]", "[LOCATION]", "[KEY_RING]", "[CRYPTO_KEY]")
13941392
.toString())
13951393
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1396-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
13971394
.build();
13981395
client.composeObject(request);
13991396
Assert.fail("No exception raised");
@@ -1640,7 +1637,6 @@ public void readObjectTest() throws Exception {
16401637
.setIfMetagenerationMatch(1043427781)
16411638
.setIfMetagenerationNotMatch(1025430873)
16421639
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1643-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
16441640
.setReadMask(FieldMask.newBuilder().build())
16451641
.build();
16461642

@@ -1671,7 +1667,6 @@ public void readObjectExceptionTest() throws Exception {
16711667
.setIfMetagenerationMatch(1043427781)
16721668
.setIfMetagenerationNotMatch(1025430873)
16731669
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1674-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
16751670
.setReadMask(FieldMask.newBuilder().build())
16761671
.build();
16771672

@@ -1769,7 +1764,6 @@ public void writeObjectTest() throws Exception {
17691764
.setObjectChecksums(ObjectChecksums.newBuilder().build())
17701765
.setFinishWrite(true)
17711766
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1772-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
17731767
.build();
17741768

17751769
MockStreamObserver<WriteObjectResponse> responseObserver = new MockStreamObserver<>();
@@ -1797,7 +1791,6 @@ public void writeObjectExceptionTest() throws Exception {
17971791
.setObjectChecksums(ObjectChecksums.newBuilder().build())
17981792
.setFinishWrite(true)
17991793
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1800-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
18011794
.build();
18021795

18031796
MockStreamObserver<WriteObjectResponse> responseObserver = new MockStreamObserver<>();
@@ -1945,7 +1938,6 @@ public void rewriteObjectTest() throws Exception {
19451938
.setCopySourceEncryptionKeyBytes(ByteString.EMPTY)
19461939
.setCopySourceEncryptionKeySha256Bytes(ByteString.EMPTY)
19471940
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
1948-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
19491941
.build();
19501942

19511943
RewriteResponse actualResponse = client.rewriteObject(request);
@@ -1992,7 +1984,6 @@ public void rewriteObjectTest() throws Exception {
19921984
actualRequest.getCopySourceEncryptionKeySha256Bytes());
19931985
Assert.assertEquals(
19941986
request.getCommonObjectRequestParams(), actualRequest.getCommonObjectRequestParams());
1995-
Assert.assertEquals(request.getCommonRequestParams(), actualRequest.getCommonRequestParams());
19961987
Assert.assertTrue(
19971988
channelProvider.isHeaderSent(
19981989
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
@@ -2031,7 +2022,6 @@ public void rewriteObjectExceptionTest() throws Exception {
20312022
.setCopySourceEncryptionKeyBytes(ByteString.EMPTY)
20322023
.setCopySourceEncryptionKeySha256Bytes(ByteString.EMPTY)
20332024
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
2034-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
20352025
.build();
20362026
client.rewriteObject(request);
20372027
Assert.fail("No exception raised");
@@ -2050,7 +2040,6 @@ public void startResumableWriteTest() throws Exception {
20502040
StartResumableWriteRequest.newBuilder()
20512041
.setWriteObjectSpec(WriteObjectSpec.newBuilder().build())
20522042
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
2053-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
20542043
.build();
20552044

20562045
StartResumableWriteResponse actualResponse = client.startResumableWrite(request);
@@ -2063,7 +2052,6 @@ public void startResumableWriteTest() throws Exception {
20632052
Assert.assertEquals(request.getWriteObjectSpec(), actualRequest.getWriteObjectSpec());
20642053
Assert.assertEquals(
20652054
request.getCommonObjectRequestParams(), actualRequest.getCommonObjectRequestParams());
2066-
Assert.assertEquals(request.getCommonRequestParams(), actualRequest.getCommonRequestParams());
20672055
Assert.assertTrue(
20682056
channelProvider.isHeaderSent(
20692057
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
@@ -2080,7 +2068,6 @@ public void startResumableWriteExceptionTest() throws Exception {
20802068
StartResumableWriteRequest.newBuilder()
20812069
.setWriteObjectSpec(WriteObjectSpec.newBuilder().build())
20822070
.setCommonObjectRequestParams(CommonObjectRequestParams.newBuilder().build())
2083-
.setCommonRequestParams(CommonRequestParams.newBuilder().build())
20842071
.build();
20852072
client.startResumableWrite(request);
20862073
Assert.fail("No exception raised");

0 commit comments

Comments
 (0)
Please sign in to comment.