Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OLM action UnsupportedOperationException #1159

Closed
danielduhh opened this issue Dec 1, 2021 · 1 comment
Closed

Remove OLM action UnsupportedOperationException #1159

danielduhh opened this issue Dec 1, 2021 · 1 comment
Assignees
@JesseLovelace
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Remove client sid...

Comments

@danielduhh
Copy link
Contributor

The library throws an error when parsing unrecognized OLM actions - https://github.com/googleapis/java-storage/blob/main/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java#L551. This is not future proof as it causes old versions to break when new actions are introduced.

We should update the client to silently error, or add an additional "UNKNOWN" enum to gracefully handle these cases.
@danielduhh danielduhh added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 1, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Dec 1, 2021
@danielduhh
Copy link
Contributor Author

Pr under review #1160

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Dec 8, 2021
@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 9, 2021
@frankyn frankyn mentioned this issue Dec 13, 2021
Closed
1 task
@frankyn frankyn added this to the Remove client side validation milestone Dec 14, 2021
@frankyn frankyn closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseLovelace JesseLovelace

Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Remove client side validation
Development

No branches or pull requests
5 participants
@BenWhitehead @frankyn @danielduhh @JesseLovelace @yoshi-automation