Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. #1236

Merged
merged 9 commits into from Feb 17, 2022
Merged

docs: Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. #1236

merged 9 commits into from Feb 17, 2022

Conversation

sydney-munro
Copy link
Collaborator

@sydney-munro sydney-munro commented Feb 10, 2022 •
edited by BenWhitehead

Internal issue b/215600897

@sydney-munro sydney-munro added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Feb 10, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 10, 2022 •
edited

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sydney-munro sydney-munro requested review from a team as code owners February 10, 2022 21:31
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/samples.cfg

@BenWhitehead
Copy link
Collaborator

Owlbot is a bit aggressive and is going to clobber any changes you make to the templates. In order to allow us to change the template, we'll need to add an ignore similar to this one

java-storage/owlbot.py

Line 33 in 923ea5b

'.kokoro/presubmit/integration.cfg',

@sydney-munro sydney-munro changed the title Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. feat: Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. Feb 16, 2022
@sydney-munro @BenWhitehead
Update .kokoro/presubmit/samples.cfg
19a7ff6 
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@BenWhitehead BenWhitehead merged commit d82333b into main Feb 17, 2022
@BenWhitehead BenWhitehead deleted the print-acls branch February 17, 2022 17:36
@BenWhitehead BenWhitehead changed the title feat: Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. docs: Adding Samples for Printing Bucket ACLs and Printing Bucket ACL for a specific user. Feb 17, 2022
@release-please release-please bot mentioned this pull request Feb 17, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@frankyn frankyn Awaiting requested review from frankyn

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees

@kolea2 kolea2

Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sydney-munro @BenWhitehead @frankyn @yoshi-kokoro @kolea2