Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust retry settings for hmac samples #1303

Merged
merged 3 commits into from Mar 29, 2022
Merged

docs: adjust retry settings for hmac samples #1303

merged 3 commits into from Mar 29, 2022

Conversation

JesseLovelace
Copy link
Contributor

Adjust retry settings for HMAC samples to make sure that these requests are getting retried.

This was also needed in Go (See https://github.com/GoogleCloudPlatform/golang-samples/blob/main/storage/service_account/hmac/hmac_test.go#L195)

Should fix #1302

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Mar 18, 2022
@JesseLovelace JesseLovelace changed the title Adjust retry settings for hmac samples docs: adjust retry settings for hmac samples Mar 18, 2022
@JesseLovelace JesseLovelace requested review from a team as code owners March 29, 2022 22:14
@JesseLovelace JesseLovelace merged commit d0c5361 into main Mar 29, 2022
@JesseLovelace JesseLovelace deleted the hmacretry branch March 29, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.example.storage.ITHmacSnippets: testDeactivateHmacKey failed
3 participants