Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Refactor Custom Dual Region sample to work with API changes #1516

Merged
merged 3 commits into from Jul 20, 2022
Merged

docs: Refactor Custom Dual Region sample to work with API changes #1516

merged 3 commits into from Jul 20, 2022

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1429 ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Jul 18, 2022
@sydney-munro sydney-munro changed the title Custom dual sample docs: Custom dual sample Jul 18, 2022
@sydney-munro sydney-munro changed the title docs: Custom dual sample docs: Refactor Custom Dual Region sample to work with API changes Jul 18, 2022
@sydney-munro sydney-munro added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 18, 2022
@sydney-munro sydney-munro removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 18, 2022
@sydney-munro sydney-munro merged commit a60cace into main Jul 20, 2022
@sydney-munro sydney-munro deleted the custom-dual-sample branch July 20, 2022 16:45
@release-please release-please bot mentioned this pull request Jul 20, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Closed
sydney-munro added a commit that referenced this pull request Oct 12, 2022
@sydney-munro
docs: Refactor Custom Dual Region sample to work with API changes (#1516
bcd8da4 
)

* docs: Refactor Custom Dual Region sample to work with API changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@frankyn frankyn frankyn approved these changes

@danielbankhead danielbankhead danielbankhead approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees

@lesv lesv

Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(samples): Dual-Region Sample for Updated API
5 participants
@sydney-munro @lesv @BenWhitehead @frankyn @danielbankhead