fix: a resumable session without a Range header should be interpreted as 0 length #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
… as 0 length According to https://cloud.google.com/storage/docs/performing-resumable-uploads#status-check a 308 response that does not contain a Range header should interpret as GCS having received no data. Include x-goog-gcs-idempotency-token in Json Resumable upload debug context
BenWhitehead
force-pushed
the
idem-header-debug
branch
from
a525ed7
to
98521f2
Compare
BenWhitehead
changed the title
frankyn
reviewed
Aug 29, 2023
google-cloud-storage/src/main/java/com/google/cloud/storage/JsonResumableSessionQueryTask.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/JsonResumableSessionQueryTask.java
Outdated
Show resolved
Hide resolved
| @@ -79,6 +78,7 @@ enum JsonResumableSessionFailureScenario { | |||
| .or(matches("Content-Type")) | |||
| .or(matches("Range")) | |||
| .or(startsWith("X-Goog-Stored-")) | |||
| .or(matches("X-Goog-GCS-Idempotency-Token")) | |||
There was a problem hiding this comment.
What if the code collapsed to startsWith("X-Goog-")?
There was a problem hiding this comment.
I wanted to reduce the scope to prevent an accidental inclusion of a header that might contain a sensitive value.
If it were relaxed to x-goog- that could pull in object metadata fields which could have sensitive values.
Since these error messages go into peoples logs, we should only include what we know is safe.
frankyn
approved these changes
Aug 30, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://cloud.google.com/storage/docs/performing-resumable-uploads#status-check a 308 response that does not contain a Range header should interpret as GCS having received no data.
Include x-goog-gcs-idempotency-token in Json Resumable upload debug context