Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 #2349

Merged
merged 17 commits into from Jan 9, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 6, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 596645164

Source-Link: googleapis/googleapis@4a0e62e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a10ed6a77676c37e60799098d48d0afb16008613
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTEwZWQ2YTc3Njc2YzM3ZTYwNzk5MDk4ZDQ4ZDBhZmIxNjAwODYxMyJ9

feat: add Storage Control API

PiperOrigin-RevId: 596130676

Source-Link: googleapis/googleapis@ce07d24

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7de5bf064581832c3fff93ab51b4c0b1d0d14aa1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2RlNWJmMDY0NTgxODMyYzNmZmY5M2FiNTFiNGMwYjFkMGQxNGFhMSJ9

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 6, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Jan 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 6, 2024 04:54
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 6, 2024 04:54
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2024
@frankyn
Copy link
Member

frankyn commented Jan 8, 2024

Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2;

@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@suztomo
Copy link
Member

suztomo commented Jan 8, 2024

Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2;

I thought we didn't need it so I didn't add grpc- part in https://github.com/googleapis/java-storage/pull/2347/files. Do you need it?

@suztomo
Copy link
Member

suztomo commented Jan 8, 2024

"ci / dependencies (17)" failed https://github.com/googleapis/java-storage/actions/runs/7429540884/job/20218238157?pr=2349.

[INFO] --- maven-dependency-plugin:3.5.0:analyze (default-cli) @ proto-google-cloud-storage-control-v2 ---
Error:  Unused declared dependencies found:
Error:     com.google.api.grpc:proto-google-iam-v1:jar:1.24.0:compile

This is just a matter of removing the unused dependency from the pom.xml.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@@ -197,6 +202,7 @@
<module>google-cloud-storage</module>
<module>grpc-google-cloud-storage-v2</module>
<module>proto-google-cloud-storage-v2</module>
<module>proto-google-cloud-storage-control-v2</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sydney-munro google-cloud-storage-control module is missing. Would you add it?

Screenshot 2024-01-08 at 3 27 35 PM

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sydney-munro google-cloud-storage-control is missing pom.xml. Can you create one by copying contents from https://github.com/googleapis/java-storage/blob/main/gapic-google-cloud-storage-v2/pom.xml (You need to edit artifact IDs and might need to adjust dependencies) If that's a trouble for you, I can help.

@gcf-owl-bot gcf-owl-bot bot changed the title feat: add Storage Control API fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 Jan 8, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2024
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group ID is good.

@sydney-munro sydney-munro merged commit 578d5d0 into main Jan 9, 2024
21 checks passed
@sydney-munro sydney-munro deleted the owl-bot-copy branch January 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants