fix: update grpc handling of IAM Policy etag to account for base64 encoding #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
BenWhitehead
force-pushed
the
enable-grpc-retry-conformance-tests
branch
from
03e6c1a
to
0612172
Compare
BenWhitehead
force-pushed
the
fix-iampolicy-b64
branch
from
5b9675e
to
41f5eb7
Compare
frankyn
reviewed
Apr 17, 2024
| @@ -1058,7 +1065,7 @@ private Policy policyDecode(com.google.iam.v1.Policy from) { | |||
| Policy.Builder to = Policy.newBuilder(); | |||
| ByteString etag = from.getEtag(); | |||
| if (!etag.isEmpty()) { | |||
| to.setEtag(etag.toStringUtf8()); | |||
| to.setEtag(byteStringB64StringCodec.encode(etag)); | |||
There was a problem hiding this comment.
this is very subtle how hasn't this come up before?
There was a problem hiding this comment.
I think setIamPolicy so far has been exclusively used in json or grpc, and not yet mixed. With the conformance tests we did get mixing, because the policy is resolved in setup via json the modified via grpc.
frankyn
approved these changes
Apr 17, 2024
…coding Etags returned by the JSON api are base64 encoded, and IAM Policy is currently modeled around this for its public api. Update GrpcConversions to base64 decode/encode appropriately.
BenWhitehead
force-pushed
the
fix-iampolicy-b64
branch
from
41f5eb7
to
15ebc51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etags returned by the JSON api are base64 encoded, and IAM Policy is currently modeled around this for its public api. Update GrpcConversions to base64 decode/encode appropriately.