Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up projectId from keyFilename #380

Open
golopot opened this issue Jun 21, 2019 · 0 comments
Open

Pick up projectId from keyFilename #380

golopot opened this issue Jun 21, 2019 · 0 comments
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@golopot
Copy link

golopot commented Jun 21, 2019

Describe the solution you'd like
Automatically fill in projectId if keyFilename is provided and resolves to a json file.

const errors = new ErrorReporting({
  // projectId: 'no need to fill in this field',
  keyFilename: <path>,
}

Additional context
@google-cloud/logging-winston does this.

https://github.com/googleapis/nodejs-logging-winston/blob/b202975b1d000e320b7416f5a3b2a527eb4e7f83/src/types/core.d.ts#L68-L74

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 22, 2019
@bcoe bcoe added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jun 25, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Jan 30, 2020
@losalex losalex self-assigned this Jun 5, 2022
@losalex losalex added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 1, 2022
@losalex losalex removed their assignment Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants