Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unskip system tests that were failing #717

Open
sofisl opened this issue Aug 15, 2023 · 1 comment
Open

chore: unskip system tests that were failing #717

sofisl opened this issue Aug 15, 2023 · 1 comment
Assignees
@daniel-sanche
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@sofisl
Copy link
Contributor

sofisl commented Aug 15, 2023 •
edited

During the Node 14 migration, I skipped some handwritten system tests that were silently failing. It seems like no one is responsible for those tests, so it would be worth fixing them once this repo gets some love again.

See #715
@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 15, 2023
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Aug 15, 2023
@sofisl sofisl added type: process A process-related concern. May include testing, release, or the like. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. labels Aug 15, 2023
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Aug 16, 2023
@meredithslota meredithslota added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: process A process-related concern. May include testing, release, or the like. labels Oct 19, 2023
@meredithslota
Copy link
Contributor

I'm marking this as a bug because I think we should investigate this sooner to ensure we're not shipping customer-impacting bugs.

@meredithslota meredithslota mentioned this issue Oct 19, 2023
Open
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniel-sanche @meredithslota @sofisl