Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitive dependency on deprecated punycode node module #741

Open
leoschweizer opened this issue Apr 30, 2024 · 0 comments
Open

transitive dependency on deprecated punycode node module #741

leoschweizer opened this issue Apr 30, 2024 · 0 comments
Assignees
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@leoschweizer
Copy link

leoschweizer commented Apr 30, 2024

This library transitively depends on ent, which uses the now deprecated node module punycode.

npm ls ent
...
└─┬ ...
  └─┬ @google-cloud/error-reporting@3.0.5
    └─┬ @google-cloud/common@4.0.3
      └── ent@2.2.0

This results in a deprecation warning when running on node >= 21:

(node:23520) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

This has been adressed in @google-cloud/common, see: googleapis/nodejs-common#812 - however @google-cloud/error-reporting does not depend on an up to date version of this library.

So @google-cloud/common must be updated to maintain compatibility with upcoming node releases. Edit: more precisely, @google-cloud/common has been updated on the main branch already here https://github.com/googleapis/nodejs-error-reporting/pull/715/files - but this is still unreleased!

Environment details

  • OS: macos
  • Node.js version: 22.0.0
  • npm version: 10.5.1
  • @google-cloud/error-reporting version: 3.0.5
@leoschweizer leoschweizer added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 30, 2024
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Apr 30, 2024
@leoschweizer leoschweizer changed the title transitive dependency on deprecated node module usage transitive dependency on deprecated punycode node module Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants