Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate red black tree from bintrees to js-sdsl #1778

Open
ZLY201 opened this issue Sep 23, 2022 · 1 comment
Open

Migrate red black tree from bintrees to js-sdsl #1778

ZLY201 opened this issue Sep 23, 2022 · 1 comment
Assignees
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ZLY201
Copy link

ZLY201 commented Sep 23, 2022

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.

Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/

Now, we published the version 4.1.5-beta.1.

I see you are using functional-red-black-tree.

In benchmark, we have confirmed that Js-sdsl is several times faster than functional-red-black-tree.

I've submitted a PR to eslint and has been accepted.

See eslint/eslint#16255 and eslint/eslint#16267.

I am willing to submit a pull request for this change.

Looking forward to your reply! :D

Describe the solution you'd like

Migrate red black tree from bintrees to js-sdsl.

Describe alternatives you've considered

Migrate red black tree from bintrees to js-sdsl.

@ZLY201 ZLY201 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 23, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Sep 23, 2022
@ehsannas
Copy link
Contributor

Thanks for the recommendation @ZLY201 . We will take it into consideration.

@ehsannas ehsannas self-assigned this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants