Fix partial upload (of a stream) issue in the event when access token is refreshed automatically. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
AVaksman
changed the title
ajaaym
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
jkwlui
approved these changes
Dec 26, 2018
|
:waves: please follow up with a unit test for this one if possible |
I am following with a related PR #67 and will add a Unit Test there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-api-nodejs-client/issues/1457
Prevent premature closure of
rStream.on('end')listener frompart.body(readable stream) topStreamto make sure thatrStreamis not closed before it consumed all data frompStream.