Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRequest util and express middleware fields #1238

Open
galaxyfeeder opened this issue Mar 24, 2022 · 1 comment
Open

HttpRequest util and express middleware fields #1238

galaxyfeeder opened this issue Mar 24, 2022 · 1 comment
Assignees
@cindy-peng
Labels
api: logging Issues related to the googleapis/nodejs-logging API. needs more info This issue needs more information from the customer to proceed.

Comments

@galaxyfeeder
Copy link

I've just installed the express middleware provided and I've seen that there are some fields that are not mapped between the express Request/Response and the HttpRequest of the LogEntry.

I would like to know if there is any reason why the remoteIp and requestSize are not parsed from requests objects, if there is any specific reason.

remoteIp can be obtained from req.ip as stated here.
requestSize can be obtained from requests headers in the same way that is done for the responseSize.
@galaxyfeeder galaxyfeeder added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Mar 24, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Mar 24, 2022
@losalex losalex assigned losalex and unassigned arbrown Mar 24, 2022
@losalex losalex removed their assignment Jul 3, 2023
@cindy-peng cindy-peng self-assigned this Jan 9, 2024
@cindy-peng
Copy link
Contributor

Hi @galaxyfeeder, are you still running into this issue? If so, do you mind sharing an example so I can try repro?

@triplequark triplequark added needs more info This issue needs more information from the customer to proceed. and removed type: question Request for information or clarification. Not an issue. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/nodejs-logging API. needs more info This issue needs more information from the customer to proceed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arbrown @galaxyfeeder @losalex @triplequark @cindy-peng