Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM support #1287

Open
GriffinJohnston opened this issue May 27, 2022 · 1 comment
Open

ESM support #1287

GriffinJohnston opened this issue May 27, 2022 · 1 comment
Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@GriffinJohnston
Copy link

GriffinJohnston commented May 27, 2022 •
edited

It's all in the title. We're well into 2022, ESM is fully supported by Node. Are there any plans to add support to this library? Thank you!
@GriffinJohnston GriffinJohnston added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 27, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label May 27, 2022
@weyert
Copy link

weyert commented Jun 13, 2022

Please don't drop CommonJs support while adding ESM support

@arbrown arbrown mentioned this issue Jul 12, 2022
Closed
@losalex losalex removed their assignment Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weyert @GriffinJohnston @losalex