Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom data to request log when provided #1430

Closed
wants to merge 1 commit into from
Closed

add custom data to request log when provided #1430

wants to merge 1 commit into from

Conversation

quixoten
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1429 馃

@quixoten quixoten requested review from a team as code owners July 12, 2023 16:26
@google-cla
Copy link

google-cla bot commented Jul 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/nodejs-logging API. labels Jul 12, 2023
@quixoten quixoten force-pushed the dc/customize-logged-req-data branch from ba80b29 to 68456b2 Compare July 12, 2023 16:31
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Aug 12, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add custom data to request log when provided
3 participants
@quixoten @daniel-sanche @meredithslota