logging: OpenTelemetry spans are ignored as parents for LogRecords

[cindy-peng]

Tracking the same issue as 9302 to propagate correct TraceId and SpanId for logging and tracing correlation.

Client

nodejs-logging

Context

In nodejs-logging libraries, the current implementation will always use a remote trace ID and span ID parsed from HTTP headers that originate from outside the application:

nodejs-logging/src/utils/context.ts

Line 95 in 53c5c24

export function getOrInjectContext(

As a result, logs are associated with the parent span rather than the span of interest.

Expected behavior

If the user is using opentelemetry instrumentation, we want to use the traceID and spanID of the span that OpenTelemetry created. This way, when a user looks for logs associated with that span, the logs produced by this logging library will appear.

[cindy-peng]

To fix this issue in nodejs logging repo, @dashpole suggested importing OpenTelemetry Api and using nodejs spanContext to retrieve current traceId and spanId:googleapis/google-cloud-go#9302 (comment)

@aabmass David mentioned that you may help review the fixes for nodejs and java. I added the following logic to retrieve spanContext locally and it seemed working fine locally:

import { trace, context, isSpanContextValid} from '@opentelemetry/api';
import { isTracingSuppressed } from '@opentelemetry/core';

   const activeContext = context.active();
    const spanContext = trace.getSpanContext(activeContext);

    if (spanContext != undefined && isSpanContextValid(spanContext) && !isTracingSuppressed(activeContext)) {
      const otelSpanContext = {
        trace: spanContext?.traceId,
        spanId: spanContext?.spanId,
        traceSampled: spanContext?.traceFlags === 1,
      };
    }

I am wondering if you can help with a couple of questions:

1. is context.active() the correct way to get the current active context and we can then use it to retrieve spanContext? It's mentioned that context.active() will work only with context Manager configured, otherwise it will always return ROOT_CONTEXT: https://opentelemetry.io/docs/languages/js/context/#active-context
   Do we need to configure context Manger in that case?

2. Do you think we need to validate !isTracingSuppressed(activeContext) as well? Looks like this is introduced from opentelemetry-core

Thank you!