Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to have test for request batching #870

Open
alexander-fenster opened this issue Aug 11, 2020 · 2 comments
Open

need to have test for request batching #870

alexander-fenster opened this issue Aug 11, 2020 · 2 comments
Assignees
@alexander-fenster
Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alexander-fenster
Copy link
Contributor

As reported in #835, we lost the batching functionality because of a bug in the generator. Unfortunately, the tests did not catch it. We need to cover this piece of functionality with tests (possibly mocking the part that makes an actual request with sinon, and checking how many times it is called).
@alexander-fenster alexander-fenster self-assigned this Aug 11, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Aug 11, 2020
@alexander-fenster alexander-fenster mentioned this issue Aug 11, 2020
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Aug 11, 2020
@keenan-devrel keenan-devrel added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 27, 2020
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 27, 2020
@losalex losalex added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 14, 2022
@losalex
Copy link
Contributor

losalex commented Oct 14, 2022

@alexander-fenster , is this feature related to this library or needs to be implemented in gapic layer?

@alexander-fenster
Copy link
Contributor Author

@losalex Logging library is the only library that makes use of the batching feature, so it could go either way, but it will be easier to implement it here in this library. Then it can be backported to the generator if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexander-fenster @yoshi-automation @keenan-devrel @losalex