From 262ad70d3cc5e1aa8a67ece54c04920b24ceea09 Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Wed, 9 Aug 2023 14:34:03 -0700 Subject: [PATCH] chore!: update to Node 14 (#346) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * docs: fix node release schedule link Co-authored-by: Jeffrey Rennie Source-Link: https://github.com/googleapis/synthtool/commit/1a2431537d603e95b4b32317fb494542f75a2165 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 * chore!: update to Node 14 * update c8 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update sync-repo-settings.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot Co-authored-by: Sofia Leon Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> --- .github/.OwlBot.lock.yaml | 4 ++-- .github/sync-repo-settings.yaml | 2 +- .github/workflows/ci.yaml | 2 +- .gitignore | 1 + .kokoro/common.cfg | 2 +- .kokoro/continuous/{node12 => node14}/common.cfg | 2 +- .kokoro/continuous/{node12 => node14}/lint.cfg | 0 .kokoro/continuous/{node12 => node14}/samples-test.cfg | 0 .kokoro/continuous/{node12 => node14}/system-test.cfg | 0 .kokoro/continuous/{node12 => node14}/test.cfg | 0 .kokoro/presubmit/{node12 => node14}/common.cfg | 2 +- .kokoro/presubmit/{node12 => node14}/samples-test.cfg | 0 .kokoro/presubmit/{node12 => node14}/system-test.cfg | 0 .kokoro/presubmit/{node12 => node14}/test.cfg | 0 .kokoro/release/docs.cfg | 2 +- .kokoro/release/publish.cfg | 2 +- .kokoro/samples-test.sh | 2 +- .kokoro/system-test.sh | 2 +- .kokoro/test.bat | 2 +- .kokoro/test.sh | 2 +- README.md | 2 +- package.json | 10 +++++----- samples/package.json | 2 +- 23 files changed, 21 insertions(+), 20 deletions(-) rename .kokoro/continuous/{node12 => node14}/common.cfg (89%) rename .kokoro/continuous/{node12 => node14}/lint.cfg (100%) rename .kokoro/continuous/{node12 => node14}/samples-test.cfg (100%) rename .kokoro/continuous/{node12 => node14}/system-test.cfg (100%) rename .kokoro/continuous/{node12 => node14}/test.cfg (100%) rename .kokoro/presubmit/{node12 => node14}/common.cfg (89%) rename .kokoro/presubmit/{node12 => node14}/samples-test.cfg (100%) rename .kokoro/presubmit/{node12 => node14}/system-test.cfg (100%) rename .kokoro/presubmit/{node12 => node14}/test.cfg (100%) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 21ad18b..a3d003c 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:0527a86c10b67742c409dc726ba9a31ec4e69b0006e3d7a49b0e6686c59cdaa9 -# created: 2023-05-24T20:32:43.844586914Z + digest: sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 +# created: 2023-08-03T18:46:14.719706948Z diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml index 4a30a08..1350fae 100644 --- a/.github/sync-repo-settings.yaml +++ b/.github/sync-repo-settings.yaml @@ -9,9 +9,9 @@ branchProtectionRules: - "ci/kokoro: System test" - docs - lint - - test (12) - test (14) - test (16) + - test (18) - cla/google - windows - OwlBot Post Processor diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f447b84..711957b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [12, 14, 16] + node: [14, 16, 18, 20] steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 diff --git a/.gitignore b/.gitignore index e993f94..94d7296 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,4 @@ package-lock.json docs/ .coverage __pycache__ +.DS_Store \ No newline at end of file diff --git a/.kokoro/common.cfg b/.kokoro/common.cfg index 5ea81b9..032ff53 100644 --- a/.kokoro/common.cfg +++ b/.kokoro/common.cfg @@ -16,7 +16,7 @@ build_file: "nodejs-paginator/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:12-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" diff --git a/.kokoro/continuous/node12/common.cfg b/.kokoro/continuous/node14/common.cfg similarity index 89% rename from .kokoro/continuous/node12/common.cfg rename to .kokoro/continuous/node14/common.cfg index 5ea81b9..032ff53 100644 --- a/.kokoro/continuous/node12/common.cfg +++ b/.kokoro/continuous/node14/common.cfg @@ -16,7 +16,7 @@ build_file: "nodejs-paginator/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:12-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" diff --git a/.kokoro/continuous/node12/lint.cfg b/.kokoro/continuous/node14/lint.cfg similarity index 100% rename from .kokoro/continuous/node12/lint.cfg rename to .kokoro/continuous/node14/lint.cfg diff --git a/.kokoro/continuous/node12/samples-test.cfg b/.kokoro/continuous/node14/samples-test.cfg similarity index 100% rename from .kokoro/continuous/node12/samples-test.cfg rename to .kokoro/continuous/node14/samples-test.cfg diff --git a/.kokoro/continuous/node12/system-test.cfg b/.kokoro/continuous/node14/system-test.cfg similarity index 100% rename from .kokoro/continuous/node12/system-test.cfg rename to .kokoro/continuous/node14/system-test.cfg diff --git a/.kokoro/continuous/node12/test.cfg b/.kokoro/continuous/node14/test.cfg similarity index 100% rename from .kokoro/continuous/node12/test.cfg rename to .kokoro/continuous/node14/test.cfg diff --git a/.kokoro/presubmit/node12/common.cfg b/.kokoro/presubmit/node14/common.cfg similarity index 89% rename from .kokoro/presubmit/node12/common.cfg rename to .kokoro/presubmit/node14/common.cfg index 5ea81b9..032ff53 100644 --- a/.kokoro/presubmit/node12/common.cfg +++ b/.kokoro/presubmit/node14/common.cfg @@ -16,7 +16,7 @@ build_file: "nodejs-paginator/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:12-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" diff --git a/.kokoro/presubmit/node12/samples-test.cfg b/.kokoro/presubmit/node14/samples-test.cfg similarity index 100% rename from .kokoro/presubmit/node12/samples-test.cfg rename to .kokoro/presubmit/node14/samples-test.cfg diff --git a/.kokoro/presubmit/node12/system-test.cfg b/.kokoro/presubmit/node14/system-test.cfg similarity index 100% rename from .kokoro/presubmit/node12/system-test.cfg rename to .kokoro/presubmit/node14/system-test.cfg diff --git a/.kokoro/presubmit/node12/test.cfg b/.kokoro/presubmit/node14/test.cfg similarity index 100% rename from .kokoro/presubmit/node12/test.cfg rename to .kokoro/presubmit/node14/test.cfg diff --git a/.kokoro/release/docs.cfg b/.kokoro/release/docs.cfg index 936cf5c..91d905e 100644 --- a/.kokoro/release/docs.cfg +++ b/.kokoro/release/docs.cfg @@ -11,7 +11,7 @@ before_action { # doc publications use a Python image. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:12-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" } # Download trampoline resources. diff --git a/.kokoro/release/publish.cfg b/.kokoro/release/publish.cfg index b617b9a..eca4197 100644 --- a/.kokoro/release/publish.cfg +++ b/.kokoro/release/publish.cfg @@ -30,7 +30,7 @@ build_file: "nodejs-paginator/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:12-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" } env_vars: { diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 806c008..8c5d108 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -56,7 +56,7 @@ fi # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=12 +COVERAGE_NODE=14 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/.kokoro/system-test.sh b/.kokoro/system-test.sh index 0201e9d..0b3043d 100755 --- a/.kokoro/system-test.sh +++ b/.kokoro/system-test.sh @@ -49,7 +49,7 @@ npm run system-test # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=12 +COVERAGE_NODE=14 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/.kokoro/test.bat b/.kokoro/test.bat index ae59e59..0bb1240 100644 --- a/.kokoro/test.bat +++ b/.kokoro/test.bat @@ -21,7 +21,7 @@ cd .. @rem we upgrade Node.js in the image: SET PATH=%PATH%;/cygdrive/c/Program Files/nodejs/npm -call nvm use v12.14.1 +call nvm use v14.17.3 call which node call npm install || goto :error diff --git a/.kokoro/test.sh b/.kokoro/test.sh index a5c7ac0..862d478 100755 --- a/.kokoro/test.sh +++ b/.kokoro/test.sh @@ -39,7 +39,7 @@ npm test # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=12 +COVERAGE_NODE=14 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/README.md b/README.md index c7c5808..e85b650 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,7 @@ also contains samples. ## Supported Node.js Versions -Our client libraries follow the [Node.js release schedule](https://nodejs.org/en/about/releases/). +Our client libraries follow the [Node.js release schedule](https://github.com/nodejs/release#release-schedule). Libraries are compatible with all current _active_ and _maintenance_ versions of Node.js. If you are using an end-of-life version of Node.js, we recommend that you update diff --git a/package.json b/package.json index b8be4df..c6424a2 100644 --- a/package.json +++ b/package.json @@ -33,18 +33,18 @@ "@compodoc/compodoc": "^1.1.7", "@types/extend": "^3.0.0", "@types/mocha": "^9.0.0", - "@types/node": "^18.0.0", + "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28", "@types/sinon": "^10.0.0", "@types/uuid": "^9.0.0", - "c8": "^7.0.0", + "c8": "^8.0.0", "codecov": "^3.0.4", - "gts": "^3.0.0", + "gts": "^5.0.0", "linkinator": "^4.0.0", "mocha": "^9.2.2", "proxyquire": "^2.0.1", "sinon": "^15.0.0", - "typescript": "^4.6.4", + "typescript": "^5.1.6", "uuid": "^9.0.0" }, "dependencies": { @@ -52,6 +52,6 @@ "extend": "^3.0.2" }, "engines": { - "node": ">=12.0.0" + "node": ">=14.0.0" } } diff --git a/samples/package.json b/samples/package.json index 1343309..7d0a3e7 100644 --- a/samples/package.json +++ b/samples/package.json @@ -3,7 +3,7 @@ "license": "Apache-2.0", "author": "Google LLC", "engines": { - "node": ">=12.0.0" + "node": ">=14.0.0" }, "repository": "googleapis/nodejs-paginator", "private": true,