Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub Topic ordered messages: should pass the acceptance tests failed #1727

Closed
flaky-bot bot opened this issue May 12, 2023 · 4 comments · Fixed by #1728
Closed

pubsub Topic ordered messages: should pass the acceptance tests failed #1727

flaky-bot bot opened this issue May 12, 2023 · 4 comments · Fixed by #1728
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 12, 2023

Note: #1715 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 146c028
buildURL: Build Status, Sponge
status: failed

Test output
Timeout of 600000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/workspace/build/system-test/pubsub.js)
Error: Timeout of 600000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/workspace/build/system-test/pubsub.js)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 12, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label May 12, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label May 13, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented May 13, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (146c028), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 23, 2023
@flaky-bot flaky-bot bot reopened this Jun 3, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 3, 2023

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: bc7e915
buildURL: Build Status, Sponge
status: failed

Test output
Expected "message5642" but received "message654" for key "CCC"
Error: Expected "message5642" but received "message654" for key "CCC"
    at Subscription. (build/system-test/pubsub.js:236:41)
        -> /workspace/system-test/pubsub.ts:344:17
    at Subscriber. (build/src/subscription.js:255:44)
        -> /workspace/src/subscription.ts:331:38
    at /workspace/build/src/lease-manager.js:207:53
        -> /workspace/src/lease-manager.ts:243:47
    at processTicksAndRejections (internal/process/task_queues.js:79:11)

@feywind
Copy link
Collaborator

feywind commented Oct 17, 2023

Yeah, it seems there's a legit flaky test thing here still.

@kamalaboulhosn kamalaboulhosn added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 1, 2024
@feywind
Copy link
Collaborator

feywind commented May 15, 2024

This happened only once, and a year ago, and I don't see anything super obviously wrong in the test itself. :| I'm just going to chalk it up to chance unless it happens again.

@feywind feywind closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants