Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sample code for tuning grpc parameters #1596

Open
rbrtwng opened this issue Mar 30, 2022 · 1 comment
Open

Provide sample code for tuning grpc parameters #1596

rbrtwng opened this issue Mar 30, 2022 · 1 comment
Assignees
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rbrtwng
Copy link

rbrtwng commented Mar 30, 2022

Cloud Bigtable allows user to override grpc parameters globally.

const bigtable = new Bigtable({
   'grpc.keepalive_time_ms': 30000,
   'grpc.keepalive_timeout_ms': 10000
});

And per offline conversation, for Cloud Spanner, you can't set these values at a global level. Instead these values can be passed with each function call. This is because for different queries number of retry values, timeout, etc make sense differently as per the operation.

Creating a FR to provide code sample in passing grpc parameters at function level.

@rbrtwng rbrtwng added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 30, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Mar 30, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 30, 2022
@rahul2393
Copy link

@surbhigarg92 please help triage this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants