fix: fix broken import for google.api_core.retry_async.AsyncRetry #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
parthea
changed the title
…nary_async.AsyncRetry
ohmayr
approved these changes
Jan 30, 2024
daniel-sanche
approved these changes
Jan 30, 2024
| "if_exception_type", | ||
| "if_transient_error", | ||
| "retry_target", | ||
| ) |
There was a problem hiding this comment.
This could also be potentially fixed with a file at google/api_core/retry_async.py, right?
Either way works for me, but it does seem like it could be confusing to have a retry_async folder, even though the actual async implementation is in /retry.
Using a retry_async.py file mirrors the old implementation, which feels slightly cleaner to me
vchudnov-g
approved these changes
Jan 30, 2024
|
Nice! Super speedy one it seems :D. Thanks for handling it that quickly :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586 🦕