Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to signatures #325

Open
4 tasks
tswast opened this issue Aug 26, 2020 · 1 comment
Open
4 tasks

Add type annotations to signatures #325

tswast opened this issue Aug 26, 2020 · 1 comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Aug 26, 2020 •
edited

@alimcmaster1 added type signatures to the gbq wrapper in pandas in pandas-dev/pandas#30632 These types can also be useful for folks that use pandas-gbq directly.

  • Add type annotations to API
  • Add type annotations to code samples
  • Add test session(s) to check types
  • Publish py.typed file
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 26, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jul 17, 2021
@tswast tswast mentioned this issue Oct 26, 2021
Closed
@tswast tswast mentioned this issue Dec 20, 2021
Merged
4 tasks
@tswast
Copy link
Collaborator Author

tswast commented Jun 27, 2022

When we do this, we may want to install the now officially supported pandas stubs to ensure pandas-gbq type checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tswast