Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use nullable Float64Dtype to allow NULL and NaN to be represented in the same Series when dtype_backend="numpy_nullable" #618

Open
tswast opened this issue Mar 7, 2023 · 1 comment
Open

feat: Use nullable Float64Dtype to allow NULL and NaN to be represented in the same Series when dtype_backend="numpy_nullable" #618

tswast opened this issue Mar 7, 2023 · 1 comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Mar 7, 2023 •
edited

The Float64Dtype more closely matches the BigQuery semantics. Ideally we'd allow folks to use this to avoid the slight data loss of mapping both NULL and NaN to NaN with the existing numpy.float64 dtype.

Edit: Per #621, we should only do this if dtype_backend="numpy_nullable".
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Mar 7, 2023
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 7, 2023
@tswast tswast mentioned this issue Mar 28, 2023
Open
@tswast
Copy link
Collaborator Author

tswast commented Mar 29, 2023

Per #621, we should only do this if dtype_backend="numpy_nullable".

@tswast tswast changed the title feat: Use nullable Float64Dtype to allow NULL and NaN to be represented in the same Series feat: Use nullable Float64Dtype to allow NULL and NaN to be represented in the same Series when dtype_backend="numpy_nullable" May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tswast