Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support the Count aggregation query #368

Merged
merged 24 commits into from Nov 1, 2022
Merged

feat: Support the Count aggregation query #368

merged 24 commits into from Nov 1, 2022

Conversation

Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Oct 3, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@Mariatta Mariatta requested review from a team as code owners October 3, 2022 22:11
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/python-datastore API. labels Oct 3, 2022
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2022
@kolea2 kolea2 changed the base branch from owl-bot-copy to main October 4, 2022 14:15
@kolea2 kolea2 changed the base branch from main to owl-bot-copy October 4, 2022 14:15
Base automatically changed from owl-bot-copy to main October 4, 2022 22:51
kolea2
kolea2 requested changes Oct 12, 2022
View reviewed changes
google/cloud/datastore/aggregation.py Outdated Show resolved Hide resolved
google/cloud/datastore/client.py Outdated Show resolved Hide resolved
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
kolea2
kolea2 requested changes Oct 19, 2022
View reviewed changes
google/cloud/datastore/aggregation.py Outdated Show resolved Hide resolved
tests/system/test_aggregation_query.py Outdated Show resolved Hide resolved
kolea2
kolea2 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like someone from @googleapis/yoshi-python to also review. Thanks!!

@Mariatta Mariatta merged commit b400a9a into main Nov 1, 2022
@Mariatta Mariatta deleted the feat-count branch November 1, 2022 17:35
@release-please release-please bot mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-datastore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mariatta @parthea @kolea2 @yoshi-kokoro