From c5a34c90ddb24bc9194a34c135c05d28612860a7 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 8 Feb 2022 13:33:57 -0800 Subject: [PATCH] lint --- samples/snippets/subscriber.py | 8 ++------ samples/snippets/subscriber_test.py | 8 +++++--- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/samples/snippets/subscriber.py b/samples/snippets/subscriber.py index 1bb60454d..dad841600 100644 --- a/samples/snippets/subscriber.py +++ b/samples/snippets/subscriber.py @@ -236,11 +236,7 @@ def create_subscription_with_filtering( with subscriber: subscription = subscriber.create_subscription( - request={ - "name": subscription_path, - "topic": topic_path, - "filter": filter, - } + request={"name": subscription_path, "topic": topic_path, "filter": filter} ) print(f"Created subscription with filtering enabled: {subscription}") # [END pubsub_create_subscription_with_filter] @@ -771,7 +767,7 @@ def callback(message: pubsub_v1.subscriber.message.Message) -> None: # [END pubsub_dead_letter_delivery_attempt] -if __name__ == "__main__": +if __name__ == "__main__": # noqa parser = argparse.ArgumentParser( description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter, ) diff --git a/samples/snippets/subscriber_test.py b/samples/snippets/subscriber_test.py index 2699f698c..9fcb1c119 100644 --- a/samples/snippets/subscriber_test.py +++ b/samples/snippets/subscriber_test.py @@ -43,7 +43,7 @@ NEW_ENDPOINT = f"https://{PROJECT_ID}.appspot.com/push2" DEFAULT_MAX_DELIVERY_ATTEMPTS = 5 UPDATED_MAX_DELIVERY_ATTEMPTS = 20 -FILTER = "attributes.author=\"unknown\"" +FILTER = 'attributes.author="unknown"' C = TypeVar("C", bound=Callable[..., Any]) @@ -401,12 +401,14 @@ def test_create_subscription_with_filtering( except NotFound: pass - subscriber.create_subscription_with_filtering(PROJECT_ID, TOPIC, SUBSCRIPTION_ADMIN, FILTER) + subscriber.create_subscription_with_filtering( + PROJECT_ID, TOPIC, SUBSCRIPTION_ADMIN, FILTER + ) out, _ = capsys.readouterr() assert "Created subscription with filtering enabled" in out assert f"{subscription_admin}" in out - assert f"filter: {FILTER}" in out + assert '"attributes.author=\\"unknown\\""' in out def test_create_push_subscription(