From fcb67dd0d8fff5a583ebe0a3a08d0219601df8e9 Mon Sep 17 00:00:00 2001 From: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com> Date: Fri, 27 May 2022 16:22:05 -0400 Subject: [PATCH] fix: add info log for bidi streaming pull ack_deadline requests (#692) * fix add info logg on bidi streaming pull ack_deadline changes * adding test coverage for logging --- .../pubsub_v1/subscriber/_protocol/streaming_pull_manager.py | 3 +++ .../unit/pubsub_v1/subscriber/test_streaming_pull_manager.py | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py b/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py index ae3635892..894c41b4c 100644 --- a/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py +++ b/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py @@ -743,6 +743,9 @@ def heartbeat(self) -> bool: request = gapic_types.StreamingPullRequest( stream_ack_deadline_seconds=self.ack_deadline ) + _LOGGER.info( + "Sending new ack_deadline of %d seconds.", self.ack_deadline + ) else: request = gapic_types.StreamingPullRequest() diff --git a/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py b/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py index 8a1460951..ad1647119 100644 --- a/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py +++ b/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py @@ -1035,7 +1035,8 @@ def test_heartbeat_inactive(): assert not result -def test_heartbeat_stream_ack_deadline_seconds(): +def test_heartbeat_stream_ack_deadline_seconds(caplog): + caplog.set_level(logging.INFO) manager = make_manager() manager._rpc = mock.create_autospec(bidi.BidiRpc, instance=True) manager._rpc.is_active = True @@ -1050,6 +1051,7 @@ def test_heartbeat_stream_ack_deadline_seconds(): assert result # Set to false after a send is initiated. assert not manager._send_new_ack_deadline + assert "Sending new ack_deadline of 10 seconds." in caplog.text @mock.patch("google.api_core.bidi.ResumableBidiRpc", autospec=True)