Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): require google-api-core>=1.31.5, >=2.3.2 #600

Merged
merged 2 commits into from Mar 4, 2022
Merged

fix(deps): require google-api-core>=1.31.5, >=2.3.2 #600

merged 2 commits into from Mar 4, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 3, 2022

fix(deps): require proto-plus>=1.15.0

@parthea
fix(deps): require google-api-core>=1.31.5, >=2.3.2
d5f2cff 
fix(deps): require proto-plus>=1.15.0
@parthea parthea requested review from a team as code owners March 3, 2022 12:37
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 3, 2022
@pradn
Copy link
Contributor

pradn commented Mar 4, 2022

@parthea What is the reason for this change?

@pradn pradn added the release-please:force-run To run release-please label Mar 4, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 4, 2022
pradn
pradn approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a more descriptive PR comment, but it's fine if that's not possible.

@parthea
Copy link
Contributor Author

parthea commented Mar 4, 2022

Thanks @pradn ! The relevant fix from google-api-core is googleapis/python-api-core#318

@parthea parthea merged commit 1608b7f into main Mar 4, 2022
@parthea parthea deleted the upgrade-google-api-core-proto-plus branch March 4, 2022 21:14
This was referenced Mar 4, 2022
Closed
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parthea @pradn