feat: Add multiprocessing and chunked downloading to transfer manager #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
andrewsg
changed the title
andrewsg
force-pushed
the
multiprocessing
branch
from
54663c0
to
286f38a
Compare
andrewsg
force-pushed
the
multiprocessing
branch
from
5e56905
to
d7f5acf
Compare
danielduhh
reviewed
Mar 9, 2023
cojenco
reviewed
Mar 10, 2023
|
System test is deadlocking due to grpc/grpc#31885, investigating workaround |
cojenco
reviewed
Mar 15, 2023
| behavior. The default is therefore to use processes instead of threads. | ||
|
|
||
| Checksumming (md5 or crc32c) is not supported for chunked operations. Any | ||
| `checksum` parameter passed in to download_kwargs will be ignored. |
There was a problem hiding this comment.
Good call out. Where are we ignoring the checksum parameter?
There was a problem hiding this comment.
Explained this offline, but for posterity, checksum is not sent by the server for ranged reads, and chunked downloads are all ranged reads, so none of the responses include a checksum. As a result, the resumable media code silently ignores the checksum parameter.
| with open(full_filename, "rb") as file_obj: | ||
| assert _base64_md5hash(file_obj) == source_file["hash"] | ||
|
|
||
| # Now test for case where last chunk is exactly 1 byte. |
There was a problem hiding this comment.
Thanks for the thorough tests! I especially like this one; really helped check the cursor moving through the last byte.
|
@cojenco @danielduhh responded to feedback, PTAL. Thanks! |
danielduhh
approved these changes
Mar 21, 2023
ddelgrosso1
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.