Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: un-deprecate blob.download_to_file() and bucket methods #1013

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

MiaCY
Copy link
Contributor

@MiaCY MiaCY commented Apr 5, 2023

Removed deprecation and warnings:

  • blob.download_to_file()
  • bucket.create()
  • bucket.list_blobs()

Removed warning in tests and renamed tests:

  • unit test test_create_w_defaults
  • unit test test_create_w_explicit

Fixes internal b/265134180

@google-cla
Copy link

google-cla bot commented Apr 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 5, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 5, 2023
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@MiaCY MiaCY added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
…t_blobs()

modify bucket method tests

change author

remove docstring 'note' of bucket.list_blobs()
@MiaCY MiaCY added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2023
@andrewsg andrewsg marked this pull request as ready for review April 27, 2023 19:29
@andrewsg andrewsg requested review from a team as code owners April 27, 2023 19:29
@andrewsg andrewsg added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2023
@andrewsg andrewsg merged commit aa4f282 into googleapis:main Apr 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants