feat: support configurable retries in upload_chunks_concurrently #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
cojenco
approved these changes
Sep 19, 2023
| @@ -1075,6 +1096,7 @@ def _upload_part( | |||
| checksum=checksum, | |||
| headers=headers, | |||
| ) | |||
| part._retry_strategy = _api_core_retry_to_resumable_media_retry(retry) | |||
There was a problem hiding this comment.
I think this would work, thanks for adding! Curious what is the idempotency for XML API multipart uploads? I see in the documentation that preconditions are not supported, but didn't see any remarks on idempotency.
There was a problem hiding this comment.
Part uploads and finalize are fully idempotent because they're associated with an upload ID.
Initialize is not fully idempotent but since an extra upload is empty and therefore not billed for storage, the consequences of occasionally getting an extra upload are near zero. I made the decision reliability in this case is better than quibbling over the details of the init call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.