Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove utcnow usage #1215

Merged
merged 7 commits into from Feb 6, 2024
Merged

fix: remove utcnow usage #1215

merged 7 commits into from Feb 6, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Feb 1, 2024

Replace datetime.utcnow which is deprecated in python 3.12

Fixes #1171
Fixes #1194

@cojenco cojenco requested review from a team as code owners February 1, 2024 23:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Feb 1, 2024
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, LGTM, thanks!

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 6, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@cojenco cojenco merged commit 8d8a53a into googleapis:main Feb 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
2 participants