Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove python 3.6 support #689

Merged
merged 4 commits into from Jan 18, 2022
Merged

feat: remove python 3.6 support #689

merged 4 commits into from Jan 18, 2022

Conversation

WildSunLove
Copy link
Contributor

No description provided.

@WildSunLove WildSunLove requested review from a team as code owners January 12, 2022 20:11
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 12, 2022
@WildSunLove WildSunLove changed the title remove python 3.6 support feat: remove python 3.6 support Jan 12, 2022
@WildSunLove WildSunLove requested a review from a team as a code owner January 12, 2022 20:15
@WildSunLove WildSunLove added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 12, 2022
@dandhlee dandhlee added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2022
@dandhlee
Copy link
Contributor

checked the CLA manually, bot seemed to have lagged. All good for CLA

@WildSunLove WildSunLove added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2022
dandhlee
dandhlee approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for samples. Confirmed 3.6 check is no longer there

@WildSunLove WildSunLove merged commit 8aa4130 into googleapis:main Jan 18, 2022
@release-please release-please bot mentioned this pull request Jan 18, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@parthea parthea Awaiting requested review from parthea parthea was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WildSunLove @dandhlee @yoshi-kokoro