Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): drop pkg_resources #744

Merged
merged 1 commit into from Mar 30, 2022
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 30, 2022

Fixes #740 馃

google-cloud-core>=1.6.0 is already listed as a dependency in setup.py. We should remove code that uses pkg_resources to check google-cloud-core>=1.6.0.

"google-cloud-core >= 1.6.0, < 3.0dev",

@parthea parthea requested review from a team as code owners March 30, 2022 13:32
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Mar 30, 2022
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@parthea parthea merged commit e963f33 into main Mar 30, 2022
@parthea parthea deleted the drop-dependency-on-pkg-resources branch March 30, 2022 23:37
@andrewsg
Copy link
Contributor

andrewsg commented Apr 4, 2022

Thanks a lot, very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add setuptools to dependencies
4 participants