Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: streamline docs for c.g.c migration #876

Merged
merged 7 commits into from
Oct 20, 2022
Merged

docs: streamline docs for c.g.c migration #876

merged 7 commits into from
Oct 20, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 27, 2022 •
edited

As part of the client libraries docs migration to cloud.google.com scheduled in Nov'22, streamline storage documentation to fit DevSite and Cloud RAD docs pipeline

  • replace in line code samples with tested snippets
  • pydocs literalinclude is currently not supported in DevSite
  • move notes and samples out of nested tables

As of right now, there is a banner on pydoc announcing the move

We're moving! Starting in November, 2022, documentation for Cloud client libraries will move to its new home on cloud.google.com. Learn more about it in our blog post: Productivity unlocked with new Cloud SDK reference docs.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Sep 27, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@cojenco cojenco marked this pull request as ready for review October 4, 2022 23:25
@cojenco cojenco requested review from a team as code owners October 4, 2022 23:25
@dandhlee dandhlee self-assigned this Oct 5, 2022
andrewsg
andrewsg approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2022
dandhlee
dandhlee approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cathy & I took a look at the docs staged, looked good! Thank you.

@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 18, 2022
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@cojenco cojenco merged commit 7c8a178 into googleapis:main Oct 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@release-please release-please bot mentioned this pull request Oct 20, 2022
Merged
rsaksham added a commit to rsaksham-dev/python-storage that referenced this pull request Oct 20, 2022
@rsaksham
Merge pull request #12 from googleapis/main
15623c4 
docs: streamline docs for c.g.c migration (googleapis#876)
@cojenco cojenco deleted the cgcdocs branch February 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@dandhlee dandhlee

Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cojenco @andrewsg @dandhlee @yoshi-kokoro