Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running on non-manifest repository fails to find prior releases #1121

Closed
bcoe opened this issue Nov 25, 2021 · 0 comments · Fixed by #1123
Closed

Running on non-manifest repository fails to find prior releases #1121

bcoe opened this issue Nov 25, 2021 · 0 comments · Fixed by #1123
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Nov 25, 2021 •
edited

Problem

Node.js' releaser, when not in manifest mode, uses the old style branch names release-v1.0.0, release-v1.1.0, etc.

I ran release-please against the yargs repo, and this was the output, due to it failing to find the prior release branches.

Reproducing

node ./build/src/bin/release-please release-pr --dry-run  --release-type=node --token=$GITHUB_TOKEN --repo-url=yargs/yargs

Expected Behavior

Historical branch names continue to work.
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 25, 2021
@chingor13 chingor13 mentioned this issue Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Manifest.fromConfig can find latest release version without component googleapis/release-please
2 participants
@chingor13 @bcoe