Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes using feat! do not show up in generated changelog #1354

Closed
joeyparrish opened this issue Mar 30, 2022 · 3 comments
Closed

Breaking changes using feat! do not show up in generated changelog #1354

joeyparrish opened this issue Mar 30, 2022 · 3 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@joeyparrish
Copy link
Contributor

joeyparrish commented Mar 30, 2022 •
edited

Environment details

  • OS: Linux (GitHub Actions, ubuntu-latest VM, via release-please-action@v3
  • Node.js version: 16.14.0
  • npm version: 8.3.1
  • release-please version: "^13.6.0" via release-please-action

Steps to reproduce

  1. Commit with a message like feat!(hls): Break everything
  2. Look for this in the changelog update of the release PR
@joeyparrish joeyparrish added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 30, 2022
@joeyparrish
Copy link
Contributor Author

Debug logging shows:

commit could not be parsed: 0daa00fc7f074c1c86968ed0fcd84bc30254ee6d feat!(hls): HLS disabled in old browsers/platforms due to incompatibilities (#3964)

This refers to shaka-project/shaka-player#3964

@joeyparrish
Copy link
Contributor Author

If I add the exception to the log, I see:

✖ Error: unexpected token '(' at 1:6, valid tokens [(, :]

Not sure what to make of this yet.

@joeyparrish
Copy link
Contributor Author

Looks like the parser wants feat!(hls) to be feat(hls)! instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeyparrish