Files are associated with PR instead of commit after rebase merge #2140
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
Darwin pieholden-m1.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103 arm64 arm Darwin
20.7.0
10.2.3
release-please
version:16.13.0
Steps to reproduce
feat: ws1
changesworkspace1/package.json
andfix: ws2
changesworkspace2/package.json
.main
Rebase and merge
release-please
onmain
to create the PRworkspace2
having received a minor version bump.Other Details
Here is a public PR where I observed this behavior: npm/cli#6609. There are a lot of unnecessary details in that PR but the specific bits are:
arborist
got bumped to6.3.0
via add new pkg fix command npm/cli#6626workspaces/arborist/
with afix:
prefixworkspaces/arborist/
with afeat:
prefixI went through the code and found that this happens because files for a merge commit are backfilled from the PR instead of the commit. This is correct when a squash merge is performed, but I think it is incorrect for rebase merges.
The text was updated successfully, but these errors were encountered: