Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty "release-as" commit not having an effect at least for betas #2231

Open
amanda-tarafa opened this issue Feb 22, 2024 · 1 comment
Open

Empty "release-as" commit not having an effect at least for betas #2231

amanda-tarafa opened this issue Feb 22, 2024 · 1 comment
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@amanda-tarafa
Copy link

I followed instructions to specify a version via an empty commit, but it didn't work. The release-please PR attempted releasing "chore(main): release Google.Api.Gax 4.7.0-beta02". I pulled the release PR and updated the versions manually.
@amanda-tarafa amanda-tarafa added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 22, 2024
@amanda-tarafa
Copy link
Author

Just to clarify, the issue is not only that the commit description has the wrong version, it's that it was actually trying to go from 4.6.0-beta02 to 4.7.0-beta02 even though I had the empty commit requesting a 4.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @amanda-tarafa