Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest release is releasing the entire repo #2276

Open
userbradley opened this issue Apr 29, 2024 · 1 comment
Open

Manifest release is releasing the entire repo #2276

userbradley opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@userbradley
Copy link

Hello,

I am following the documentation for manifest release, but when downloading the generated assets for a release, the entire repo is being included in the assets

This is the layout of the repo

.
├── helm-charts
│   ├── airflow-workload-id
│   │   ├── CHANGELOG.md
│   │   ├── Chart.yaml
│   │   ├── README.md
│   │   ├── README.md.gotmpl
│   │   ├── Taskfile.yaml
│   │   ├── templates
│   │   └── values.yaml
│   ├── codesearch
│   │   ├── Chart.yaml
│   │   ├── README.md
│   │   ├── README.md.gotmpl
│   │   ├── Taskfile.yaml
│   │   ├── templates
│   │   └── values.yaml
│   └── gcs-web-server
│       ├── CHANGELOG.md
│       ├── Chart.yaml
│       ├── README.md
│       ├── README.md.gotmpl
│       ├── Taskfile.yaml
│       ├── templates
│       └── values.yaml
└── release-please-config.json

8 directories, 18 files

And the below config files

# .release-please-manifest.json`
{
  "helm-charts/airflow-workload-id": "1.1.0",
  "helm-charts/gcs-web-server": "1.0.0",
  "helm-charts/codesearch": "1.0.0",
}

and

# release-please-config.json
{
  "bootstrap-sha": "d50c1d3d59ab955ab8b0330131c22790d8acbf1b",
  "packages": {
    "helm-charts/airflow-workload-id": {
      "changelog-path": "CHANGELOG.md",
      "release-type": "helm",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "prerelease": false
    },
    "helm-charts/codesearch": {
      "changelog-path": "CHANGELOG.md",
      "release-type": "helm",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "prerelease": false
    },
    "helm-charts/gcs-web-server": {
      "changelog-path": "CHANGELOG.md",
      "release-type": "helm",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "prerelease": false
    }
  },
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

And below is the GitHub action I am using

on:
  push:
    branches:
      - main
name: release-please
jobs:
  release-please:
    permissions:
      pull-requests: write
      contents: write
    runs-on: ubuntu-latest
    steps:
      - uses: GoogleCloudPlatform/release-please-action@v4
        id: release
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          config-file: release-please-config.json
          manifest-file: .release-please-manifest.json

I am trying to get something like https://github.com/Financial-Times/origami where each package is released as it's own thing, and the assets associated with that release are only in that folder

I'm not sure where I've gone wrong, or if this is the expected behaviour?

Docs followed: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md

@userbradley userbradley added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Apr 29, 2024
@rubiin
Copy link

rubiin commented May 17, 2024

same . The bootstrap sha is not being read, also the commit depth is always 500 even when set to something like 20 in config.json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants