Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra proto dependencies should be added to nodejs_gapic_assembly_pkg #110

Open
alexander-fenster opened this issue Aug 17, 2022 · 0 comments
Open

extra proto dependencies should be added to nodejs_gapic_assembly_pkg #110

alexander-fenster opened this issue Aug 17, 2022 · 0 comments
Assignees
@alexander-fenster
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alexander-fenster
Copy link
Member

All protos that are outside of the current package and not the "common proto" should be explicitly listed as dependencies for nodejs_gapic_assembly_pkg target.
@alexander-fenster alexander-fenster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 17, 2022
@alexander-fenster alexander-fenster self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexander-fenster