Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run actual build_gen bazel target in CI #146

Open
alexander-fenster opened this issue Mar 7, 2023 · 0 comments
Open

Run actual build_gen bazel target in CI #146

alexander-fenster opened this issue Mar 7, 2023 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@alexander-fenster
Copy link
Member

Would be nice to run the actual java_binary target in CI to make sure we don't use Java features not supported by the lowest version we claim to support (1.8). Would prevent problems like in #145 where String.isBlank started failing for some users.

java_binary(
name = "build_file_generator",
srcs = glob(["src/main/java/**/*.java"]),
resources = glob(["src/main/java/**/*.mustache"]),
data = [":buildozer_binary"],
args = ["--buildozer=$(location :buildozer_binary)"],
create_executable = True,
javacopts = ["-source", "1.8", "-target", "1.8"],
jvm_flags = ["-Xmx1024m"],
main_class = "com.google.api.codegen.bazel.BuildFileGenerator",
visibility = ["//visibility:public"],
)

@alexander-fenster alexander-fenster added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant