Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not automatically generate gapic_library targets for protos that don't have a service #43

Open
alicejli opened this issue Jun 2, 2021 · 0 comments
Open

feat: do not automatically generate gapic_library targets for protos that don't have a service #43

alicejli opened this issue Jun 2, 2021 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
build gen v2

Comments

@alicejli
Copy link

alicejli commented Jun 2, 2021

We currently generate gapic_library targets in the BUILD file for all protos, including protos that only contain messages (e.g. do not contain a service). We do not need to do that for protos that do not contain services.

We could either parse the proto itself for a service, or look at the yaml file for APIs being referenced to determine whether gapic_library targets need to be included.
@alicejli alicejli added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 2, 2021
@noahdietz noahdietz added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 2, 2021
@noahdietz noahdietz added this to the build gen v2 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
build gen v2
Development

No branches or pull requests
2 participants
@noahdietz @alicejli