Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent bazel rule names open source gapic packages #56

Open
jpoehnelt opened this issue Jun 29, 2021 · 1 comment
Open

Consistent bazel rule names open source gapic packages #56

jpoehnelt opened this issue Jun 29, 2021 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
build gen v2

Comments

@jpoehnelt
Copy link
Contributor

Currently three different versions are used in the template.

name = "google-cloud-{{assembly_name}}-{{version}}-java",
name = "gapi-cloud-{{assembly_name}}-{{version}}-go",
name = "{{assembly_name}}-{{version}}-py",

It simplifies downstream tooling if these follow a consistent pattern. What are the consequences of changing these to a single format?
@jpoehnelt jpoehnelt added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 29, 2021
@jpoehnelt
Copy link
Contributor Author

I suppose an alias could be used in the mustache template to avoid breaking changes.

This was referenced Jun 29, 2021
Open
Closed
@noahdietz noahdietz added this to the build gen v2 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
build gen v2
Development

Successfully merging a pull request may close this issue.

fix(build_gen): use consistent names for open source package
2 participants
@jpoehnelt @noahdietz