Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel template defaults to NPM @google-cloud namespace #58

Open
jpoehnelt opened this issue Jun 30, 2021 · 3 comments
Open

Bazel template defaults to NPM @google-cloud namespace #58

jpoehnelt opened this issue Jun 30, 2021 · 3 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@jpoehnelt
Copy link
Contributor

The following is hardcoded into the mustache template.

package_name = "@google-cloud/{{name}}",
@jpoehnelt jpoehnelt added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 30, 2021
@noahdietz
Copy link
Contributor

noahdietz commented Oct 5, 2021

Hey @jpoehnelt so there are several different attributes that are hardcoded with some value that includes cloud. Is it just this one field you are concerned with? Or would you like to see all such hardcoded instances of cloud removed?

Alternatively, is the PA-related naming something you'd like to see be configurable e.g. via a flag? Or is plain ol'google /not cloud sufficient?

We've got a very simple heuristic for cloud-or-not that is not widely used in the generator. We could look to expand its use to more attributes, but we'd want to make sure we don't break anything else in the corpus (there are many APIs that might look like they aren't in cloud, but actually are e.g. Pub/Sub, Spanner, etc.).

Finally, depending on what is required here, we may have to punt this to our upcoming "build_gen v2" effort. We want to rewrite the BUILD file generator using buildozer to make it way smarter/more robust.

@jpoehnelt
Copy link
Contributor Author

It is not limited to just this one.

Please note that the other solution we are assessing is just publishing everything under the cloud namespace (and letting Yoshi team do it for us). So feel free to adjust priority as you see fit.

@noahdietz
Copy link
Contributor

In that case, I think it would be better to reclassify this as a feature request and ensure that it is considered for our v2 effort.

@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 5, 2021
@noahdietz noahdietz added this to the build gen v2 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants