From 285bdb101194740a7a9618565679b7be01c70f43 Mon Sep 17 00:00:00 2001 From: Mridula <66699525+mpeddada1@users.noreply.github.com> Date: Wed, 3 Jan 2024 21:08:16 +0000 Subject: [PATCH] fix: re-enable checkstyle in sdk-platform-java-config (#2335) The checkstyle was initially disabled to address the following error when executing `mvn clean install`: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.1:check (checkstyle) on project sdk-platform-java-config: Failed during checkstyle execution: Unable to find configuration file at location: license-checks.xml: Could not find resource 'license-checks.xml'. -> [Help 1] ``` However, since this artifact is meant to be used as a parent for downstream libraries, there is a risk that the `checkstyle.skip` property will be inherited by child poms in the future. This may cause checkstyle to be unintentionally disabled. --- sdk-platform-java-config/java.header | 15 +++++++++++++++ sdk-platform-java-config/license-checks.xml | 10 ++++++++++ sdk-platform-java-config/pom.xml | 1 - 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 sdk-platform-java-config/java.header create mode 100644 sdk-platform-java-config/license-checks.xml diff --git a/sdk-platform-java-config/java.header b/sdk-platform-java-config/java.header new file mode 100644 index 0000000000..d0970ba7d3 --- /dev/null +++ b/sdk-platform-java-config/java.header @@ -0,0 +1,15 @@ +^/\*$ +^ \* Copyright \d\d\d\d,? Google (Inc\.|LLC)$ +^ \*$ +^ \* Licensed under the Apache License, Version 2\.0 \(the "License"\);$ +^ \* you may not use this file except in compliance with the License\.$ +^ \* You may obtain a copy of the License at$ +^ \*$ +^ \*[ ]+https?://www.apache.org/licenses/LICENSE-2\.0$ +^ \*$ +^ \* Unless required by applicable law or agreed to in writing, software$ +^ \* distributed under the License is distributed on an "AS IS" BASIS,$ +^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$ +^ \* See the License for the specific language governing permissions and$ +^ \* limitations under the License\.$ +^ \*/$ diff --git a/sdk-platform-java-config/license-checks.xml b/sdk-platform-java-config/license-checks.xml new file mode 100644 index 0000000000..6597fced80 --- /dev/null +++ b/sdk-platform-java-config/license-checks.xml @@ -0,0 +1,10 @@ + + + + + + + + diff --git a/sdk-platform-java-config/pom.xml b/sdk-platform-java-config/pom.xml index dc79d70a68..63b82f2bce 100644 --- a/sdk-platform-java-config/pom.xml +++ b/sdk-platform-java-config/pom.xml @@ -17,7 +17,6 @@ - true 3.20.1-SNAPSHOT \ No newline at end of file