Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generated google compute library has grpc-* directory when transport is rest #1981

Closed
JoeWang1127 opened this issue Sep 12, 2023 · 0 comments · Fixed by #1979
Closed

The generated google compute library has grpc-* directory when transport is rest #1981

JoeWang1127 opened this issue Sep 12, 2023 · 0 comments · Fixed by #1979
Assignees
@JoeWang1127
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

The google compute library generated by generate_library.sh has grpc-* directory.

This is a bug because transport is rest.

Skip generating grpc-* directory if transport is rest.
@JoeWang1127 JoeWang1127 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 12, 2023
@JoeWang1127 JoeWang1127 self-assigned this Sep 12, 2023
@JoeWang1127 JoeWang1127 linked a pull request Sep 12, 2023 that will close this issue
feat: skip generating grpc-* directory if transport is rest #1979
Merged
@JoeWang1127 JoeWang1127 mentioned this issue Sep 12, 2023
Merged
@kmaydeo kmaydeo added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeWang1127 JoeWang1127

Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skip generating grpc-* directory if transport is rest googleapis/sdk-platform-java
2 participants
@JoeWang1127 @kmaydeo